Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document yarn release, add .yarnrc & .eslintignore #5

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Conversation

kylesuss
Copy link
Contributor

@kylesuss kylesuss commented Jun 3, 2019

The .yarnrc file lets us run yarn publish without having yarn assume that we want to push to the yarn registry.

Let me know if the docs I added make sense or could be formatted any better.

I made a bit of a mess doing this publishing & unpublishing packages/changelogs, but I think I have it cleaned up now. There might be a slight issue once the next version is released as NPM won't allow 0.0.15 since I have already published & unpublished it (it had nothing in it). The package.json currently says 0.0.14 so I think auto is going to think that the next version is 0.0.15 and try to push to NPM, but that will fail. @shilman any thoughts on how to fix this?

@kylesuss kylesuss requested a review from shilman June 3, 2019 20:39

import MyComponent from "@storybook/design-system";
import MyComponent from '@storybook/design-system';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier updated this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the docs! 💪

@shilman shilman merged commit 718eee5 into master Jun 3, 2019
@kylesuss kylesuss deleted the fix-release branch June 3, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants